[PATCH xserver 2/2] damage: Support Xinerama in the Damage extension (#17013)

Aaron Plattner aplattner at nvidia.com
Wed Aug 21 13:18:14 PDT 2013


On 08/21/2013 01:10 PM, Adam Jackson wrote:
> On Mon, 2011-09-26 at 15:01 -0700, Aaron Plattner wrote:
>
>> +	/*
>> +	 * Install a wakeup handler to create the Damage objects for screens 1 and
>> +	 * up.  We need to do that after InitRootWindow is called and pScreen->root
>> +	 * is created.
>> +	 */
>
> This should probably say something other than "wakeup handler".
>
> Otherwise for the series:
>
> Reviewed-by: Adam Jackson <ajax at redhat.com>

Heh, blast from the past.

I think I abandoned this series after I realized that this only worked 
for Damage objects tracking the root window, but didn't work for Damage 
on other windows.  I ended up never getting back to it.

This series is definitely better than the behavior the server has now, 
so maybe it would be a good idea to apply it anyway and try to fix it 
better later (i.e. in another two years).

-- 
Aaron


More information about the xorg-devel mailing list