[PATCH imake] Replace fprintf with fputs

Alan Coopersmith alan.coopersmith at oracle.com
Sat Aug 17 10:20:50 PDT 2013


On 08/17/13 05:17 AM, Julien Cristau wrote:
> Fixes build failure with -Werror=format-security:
> imake.c:1008:5: error: format not a string literal and no format arguments [-Werror=format-security]
>       fprintf (inFile, command);
>       ^
>
> Signed-off-by: Julien Cristau <jcristau at debian.org>
> ---
>   imake.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/imake.c b/imake.c
> index 7ea13e6..c20cd4a 100644
> --- a/imake.c
> +++ b/imake.c
> @@ -1005,7 +1005,7 @@ get_libc_version(FILE *inFile)
>       abort ();
>
>     while (fgets (command, len, fp))
> -    fprintf (inFile, command);
> +    fputs (command, inFile);
>
>     len = pclose (fp);
>     remove (aout);
>

Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc


More information about the xorg-devel mailing list