[PATCH] Use the right variable names for the compiler flags in XORG_TESTSET_CFLAGS

Alan Coopersmith alan.coopersmith at oracle.com
Mon Aug 5 09:12:31 PDT 2013


On 08/ 5/13 09:00 AM, Sedat Dilek wrote:
> On Mon, Aug 5, 2013 at 5:52 PM, Sedat Dilek <sedat.dilek at gmail.com> wrote:
>> Can you unify and beautify the output?
>>
>> checking if clang supports[space]... <--- [space] is not always seen
>> in the output!
>>
>
> That seems to do the trick here:
>
> [ /usr/share/aclocal/xorg-macros.m4 ]
>
>   dnl Some hackery here since AC_CACHE_VAL can't handle a non-literal varname
> -               AC_MSG_CHECKING([if ]COMPILER[ supports]flag[])
> +               AC_MSG_CHECKING([if ]COMPILER[ supports ]flag[])
>                  cacheid=AS_TR_SH([xorg_cv_]CACHE_PREFIX[_flag_]flag[])
>                  AC_CACHE_VAL($cacheid,
>                               [AC_LINK_IFELSE([AC_LANG_PROGRAM([int i;])],

That's already fixed in git master:
http://cgit.freedesktop.org/xorg/util/macros/commit/xorg-macros.m4.in?id=0890e4003aacfa7113ab3f4e3ad7c5636f8e922a
just hasn't been pushed out to a release yet.

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc


More information about the xorg-devel mailing list