[PATCH] Use the right variable names for the compiler flags in XORG_TESTSET_CFLAGS

[Chris Wilson]

On Mon, Aug 05, 2013 at 06:00:05PM +0200, Sedat Dilek wrote:
> On Mon, Aug 5, 2013 at 5:52 PM, Sedat Dilek <sedat.dilek at gmail.com> wrote:
> > On Mon, Aug 5, 2013 at 5:08 PM, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> >> Whilst populating the xorg_cv_ cache entries, and the subsequent
> >> xorg_testset_, we always include the FLAG_PREFIX in the name, to
> >> distinguish between C and C++ iterations. However, in the body of the
> >> test function, we dropped the FLAG_PREFIX expansion and so always used
> >> the empty string and hence did not correctly detect incorrect flags.
> >>
> >> The bug was introduced with
> >> commit 51f69514e65637f575df901ef942515e70314f6a
> >> Author: Chase Douglas <chase.douglas at canonical.com>
> >> Date:   Mon Mar 12 11:49:28 2012 -0700
> >>
> >>     Separate unknown warning options by language
> >>
> >> Reported-by: Sedat Dilek <sedat.dilek at gmail.com>
> >> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> >> Cc: Sedat Dilek <sedat.dilek at gmail.com>
> >> Cc: Chase Douglas <chase.douglas at canonical.com>
> >> Cc: Gaetan Nadon<memsize at videotron.ca>
> >> ---
> >
> > Tested-by: Sedat Dilek <sedat.dilek at gmail.com> [ as told on intel-gfx ML ]
> >
> > Can you unify and beautify the output?
> >
> > checking if clang supports[space]... <--- [space] is not always seen
> > in the output!
> >
> 
> That seems to do the trick here:
> 
> [ /usr/share/aclocal/xorg-macros.m4 ]
> 
>  dnl Some hackery here since AC_CACHE_VAL can't handle a non-literal varname
> -               AC_MSG_CHECKING([if ]COMPILER[ supports]flag[])
> +               AC_MSG_CHECKING([if ]COMPILER[ supports ]flag[])
>                 cacheid=AS_TR_SH([xorg_cv_]CACHE_PREFIX[_flag_]flag[])
>                 AC_CACHE_VAL($cacheid,
>                              [AC_LINK_IFELSE([AC_LANG_PROGRAM([int i;])],
> 
> $ grep ^'checking if clang supports'
> logs/build-and-install-log_XF86-Video-Intel-v2-21-14_issues-fixed-beautified-output_llvm-3-3.txt
> | grep Wno
> checking if clang supports -Wno-cast-qual... yes
> checking if clang supports -Wno-redundant-decls... yes
> checking if clang supports -Wno-maybe-uninitialized... no
> 
> Chris, you want a separate fix or fold this into this one and send a v2?

That patch is already sitting upstream:

commit 0890e4003aacfa7113ab3f4e3ad7c5636f8e922a
Author: Yaakov Selkowitz <yselkowitz at users.sourceforge.net>
Date:   Tue Apr 3 18:43:02 2012 -0500

    Fix spacing in XORG_TESTSET_CFLAG
    
    Signed-off-by: Yaakov Selkowitz <yselkowitz at users.sourceforge.net>
    Reviewed-by: Gaetan Nadon <memsize at videotron.ca>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre