[PATCH 00/18] Xfbdev Atari and Amiga support

[Alan Coopersmith]

On 04/24/13 10:00 PM, Keith Packard wrote:
> Alan Coopersmith <alan.coopersmith at oracle.com> writes:
>
>> On 04/24/13 06:58 PM, Keith Packard wrote:
>>> Alan Coopersmith <alan.coopersmith at oracle.com> writes:
>>>
>>>> This broke my build:
>>>>
>>>> Undefined                       first referenced
>>>>    symbol                             in file
>>>> c2p_unsupported
>>>> ../../../miext/shadow/.libs/libshadow.a(shafb4.o)
>>>
>>> Builds fine with GCC; perhaps that figures out that this function can
>>> never be called?
>>
>> If I build with gcc 4.7.2 with -O2 it indeed optimizes it out.
>> If I build with gcc 4.7.2 with -g and no -O flags, it fails the same
>> way.
>
> That makes sense at least. We could either make c2p_unsupported call
> FatalError or just be a no-op. Any preference?

I'd prefer at least a BUG_WARN() over a no-op, to give us a hint why
stuff isn't working, though FatalError() also works for something that
should be impossible to hit.

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc