[xserver 1.14/master] dixstruct.h: fix segfaults - char is unsigned for ARM and PowerPC architectures

Mark Kettenis mark.kettenis at xs4all.nl
Mon Apr 22 15:03:13 PDT 2013


> Date: Mon, 22 Apr 2013 23:17:56 +0200
> From: =?UTF-8?Q?Andreas_M=C3=BCller?= <schnitzeltony at googlemail.com>
> 
> On Tue, Apr 16, 2013 at 2:30 PM, Andreas Müller
> <schnitzeltony at googlemail.com> wrote:
> > see ARM related bug reports [1-3]
> >
> > [1] https://github.com/archlinuxarm/PKGBUILDs/issues/446I
> > [2] http://www.raspberrypi.org/phpBB3/viewtopic.php?t=38568&p=321673
> > [3] http://lists.linuxtogo.org/pipermail/openembedded-core/2013-April/037805.html
> >
> > Signed-off-by: Andreas Müller <schnitzeltony at googlemail.com>
> > ---
> >  include/dixstruct.h |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/include/dixstruct.h b/include/dixstruct.h
> > index 6784819..aef822c 100644
> > --- a/include/dixstruct.h
> > +++ b/include/dixstruct.h
> > @@ -96,7 +96,7 @@ typedef struct _Client {
> >      unsigned int clientGone:1;
> >      unsigned int closeDownMode:2;
> >      unsigned int clientState:2;
> > -    char smart_priority;
> > +    signed char smart_priority;
> >      short noClientException;      /* this client died or needs to be killed */
> >      int priority;
> >      ReplySwapPtr pSwapReplyFunc;
> > --
> > 1.7.6.5
> >
> Meanwhile I have feedback from all projects above: This patch turns
> xserver into usable for ARM - ping?

Reviewed-by: Mark Kettenis <kettenis at openbsd.org>


More information about the xorg-devel mailing list