[PATCH 0/6] xfree86: Handle drm race condition

Bryce Harrington bryce at canonical.com
Tue Apr 9 11:47:32 PDT 2013


On Mon, Apr 08, 2013 at 03:50:16PM -0700, Keith Packard wrote:
> Dave Airlie <airlied at gmail.com> writes:
> 
> > Don't think I did, from what I can see these are just local Ubuntu
> > races at startup between plymouth, lightdm and X,
> 
> Maybe I was misreading stuff, but I saw a separate kernel thread about
> the X server failing to implicitly become master because some other
> process had recently closed the last DRI file but that hadn't been
> cleaned up by the time the X server came around

That was one of several ideas that were chased down.  That may have been
a legitimate issue, but (as we suspected at the outset) the issue turned
out to be a race between lightdm and plymouth-splash; upstart was
starting them in parallel when they should be sequential, IIRC.

That change hasn't landed yet, but is a trivial change, and I think we can
roll it into prior ubuntu releases as needed.  We're still testing but
word so far is it fixes it 100%.

> > I don't think any of this should have been merged.
> 
> If they make it easier for Ubuntu users to build and use upstream, I
> think they should be included. I didn't see anything in them that made
> me think they'd hurt anyone else.

I don't think they'll hurt anyone but to be honest once we have the
upstart rule added this workaround will be entirely unnecessary I
think.

So, feel free to revert the patches if the thinking is it's just adding
clutter, but you may still want the first patch in the series as it adds
a missing close().  We also found that having the server print out the
error code helped in diagnosing the problem.

Bryce


More information about the xorg-devel mailing list