[PATCH] Fix a bug for calling createContextAttribs.

He Junyan junyan.he at linux.intel.com
Fri Sep 28 19:16:25 PDT 2012


On 09/29/2012 12:05 AM, Ian Romanick wrote:
> On 09/27/2012 03:29 PM, junyan.he at linux.intel.com wrote:
>> From: Junyan He <junyan.he at linux.intel.com>
>>
>>   __glXDisp_CreateNewContext path will call the
>>   __glXDRIscreenCreateContext with no attribs, and
>>   cause api not inited and has a random value.
>
> api should be initialized in dri2_convert_glx_attribs like major_ver, 
> minor_ver, and reset.
I don't know the default value for these variables.
In the function call path I listed, num_attribs is 0 and 
dri2_convert_glx_attribs will not be called.

>
>> Signed-off-by: Junyan He <junyan.he at linux.intel.com>
>> ---
>>   glx/glxdri2.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/glx/glxdri2.c b/glx/glxdri2.c
>> index bce1bfa..e34c851 100644
>> --- a/glx/glxdri2.c
>> +++ b/glx/glxdri2.c
>> @@ -544,6 +544,8 @@ create_driver_context(__GLXDRIcontext * context,
>>                   ctx_attribs[num_ctx_attribs++] = reset;
>>               }
>>   #endif
>> +        } else {
>> +            api = __DRI_API_OPENGL;
>>           }
>>
>>           context->driContext =
>>
>
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
>



More information about the xorg-devel mailing list