[PATCH xorg-gtest 0/4] Test speedup patches
chase.douglas at ubuntu.com
Wed Sep 26 14:40:53 PDT 2012
On Mon, Sep 24, 2012 at 5:34 PM, Peter Hutterer
<peter.hutterer at who-t.net> wrote:
> Found a bit of time to investigate why the tests are so slow and it
> turns out the slow testing was caused by unecessary sleeps in the test
> Patches 1 and 3 get the average test time for very basic tests from ~1500ms
> down to around 145ms. The other two are auxiliary patches.
> A bit more time can be shaved off with -noreset, but that currently has to
> be set by the client, any caller that uses WaitForConnection() will cause a
> server reset. Not ideal, but I'm too jetlagged to have found a nice solution
> to this yet.
These all look good to me. I was initially trying to not overburden
the system with polling, but this isn't code that will be run in
production. There is no point in wasting development time when
computers are happy to poll quite often :).
Reviewed-by: Chase Douglas <chase.douglas at ubuntu.com>
More information about the xorg-devel