[PATCH 0/3] Fix initialization when iopl is forbidden

Adam Jackson ajax at redhat.com
Thu Sep 20 08:13:17 PDT 2012

On 9/20/12 9:42 AM, Keith Packard wrote:
> Adam Jackson <ajax at redhat.com> writes:
>> Will resend with better commentary, thanks.
> Do you have this series with new commentary added? Otherwise, I'll just
> merge it as-is.

I do, for a loose definition of "added" and/or "commentary":


What that actually does is remove the "do we want it" comment in favor 
of a new Bool want_hw_access.  We set that based on the result of the 
GET_REQUIRED_HW_INTERFACES loop, and only later set the (global) 
xorgHWAccess based on whether xf86EnableIO() succeeded.

Why make the comments speak better if you can make the code speak 
better, after all.

- ajax

More information about the xorg-devel mailing list