[PATCH vmmouse] Log in VMMouseReadInput() in a signal-safe manner
Geoffrey Thomas
geofft at ldpreload.com
Sat Sep 8 16:31:02 PDT 2012
This fixes the following message from Xorg.0.log:
(EE) BUG: triggered 'if (inSignalContext)'
(EE) BUG: ../../os/log.c:484 in LogVMessageVerb()
(EE) Warning: attempting to log data in a signal unsafe manner while in signal context.
Please update to check inSignalContext and/or use LogMessageVerbSigSafe() or ErrorFSigSafe().
The offending log format message is:
VMWARE(0): vmmouse enable absolute mode
I haven't seen that complaint about other log messages, but it's possible
other calls to xf86Msg in this code should also be changed.
Signed-off-by: Geoffrey Thomas <geofft at ldpreload.com>
---
src/vmmouse.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/vmmouse.c b/src/vmmouse.c
index 590144f..569776f 100644
--- a/src/vmmouse.c
+++ b/src/vmmouse.c
@@ -1063,7 +1063,7 @@ VMMouseReadInput(InputInfoPtr pInfo)
*/
VMMouseClient_RequestAbsolute();
mPriv->absoluteRequested = TRUE;
- xf86Msg(X_INFO, "VMWARE(0): vmmouse enable absolute mode\n");
+ LogMessageVerbSigSafe(X_INFO, 1, "VMWARE(0): vmmouse enable absolute mode\n");
}
/*
--
1.7.10.4
More information about the xorg-devel
mailing list