[PATCH:xscope 04/24] Convert some for loops to use C99-style inline variable declarations

Daniel Stone daniel at fooishbar.org
Sat Sep 1 09:59:52 PDT 2012


Hi,

On 1 September 2012 03:33, Mark Kettenis <mark.kettenis at xs4all.nl> wrote:
>> From: Alan Coopersmith <alan.coopersmith at oracle.com>
>> Date: Fri, 31 Aug 2012 22:17:46 -0700
>
> Please don't do this.  Some OpenBSD platforms are still stuck with GCC
> 2.95.3.  GCC 2.95.3 is almost a C99 compiler, but doesn't support the
> C99 (mis)feature of allowing variable declarations after statements.
> That's always been a controversial feature, although using it to
> declare loop variables inside a for statement like you're doing here
> is fairly widely accepted.

Yes, and 2.95 is thirteen years old.  A teenager which is eyeing off
your car keys.

If a platform still hasn't been updated to a new compiler in that
timeframe, I don't think it's something we should particularly worry
about.

Cheers,
Daniel


More information about the xorg-devel mailing list