[PATCH libX11] XIM: remove Private and Public macros

Jon TURNEY jon.turney at dronecode.org.uk
Mon Oct 29 15:12:43 PDT 2012


On 22/10/2012 19:59, Yaakov (Cygwin/X) wrote:
> From: Yaakov Selkowitz <yselkowitz-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f at public.gmane.org>
> 
> Private is a struct member name in mingw-w64 <winioctl.h>, causing this
> useless define in a private header to break the build.

This hunk has wrong whitespace

> diff --git a/modules/im/ximcp/imRmAttr.c b/modules/im/ximcp/imRmAttr.c
> index c047715..1860162 100644
> --- a/modules/im/ximcp/imRmAttr.c
> +++ b/modules/im/ximcp/imRmAttr.c
> @@ -859,7 +859,7 @@ _XimEncodeIMATTRIBUTE(
>  }
>  
>  #ifdef XIM_CONNECTABLE
> -Public	Bool
> +	Bool
>  _XimEncodeSavedIMATTRIBUTE(
>      Xim			 im,
>      XIMResourceList	 res_list,

With that fixed, Reviewed-by: Jon TURNEY <jon.turney at dronecode.org.uk>

Yes, I read the whole thing.



More information about the xorg-devel mailing list