[PATCH 12/12] dri2: Don't bother with xf86LoaderCheckSymbol("DRI2Connect")

Ian Romanick idr at freedesktop.org
Mon Oct 29 11:12:34 PDT 2012


On 10/16/2012 11:56 AM, Adam Jackson wrote:
> The DRI2 code is now built-in to the server, even for Xorg.  The only
> thing this could protect against is trying to run a libglx built with
> DRI2 support against an Xorg built without it, which is firmly in
> "doctor it hurts when I do this" territory.
>
> Signed-off-by: Adam Jackson <ajax at redhat.com>

This patch is:

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

> ---
>   glx/glxdri2.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/glx/glxdri2.c b/glx/glxdri2.c
> index 0ce40ca..e5efc31 100644
> --- a/glx/glxdri2.c
> +++ b/glx/glxdri2.c
> @@ -890,8 +890,7 @@ __glXDRIscreenProbe(ScreenPtr pScreen)
>       if (screen == NULL)
>           return NULL;
>
> -    if (!xf86LoaderCheckSymbol("DRI2Connect") ||
> -        !DRI2Connect(serverClient, pScreen, DRI2DriverDRI,
> +    if (!DRI2Connect(serverClient, pScreen, DRI2DriverDRI,
>                        &screen->fd, &driverName, &deviceName)) {
>           LogMessage(X_INFO,
>                      "AIGLX: Screen %d is not DRI2 capable\n", pScreen->myNum);
>



More information about the xorg-devel mailing list