[PATCH lib/libXpm] Define NO_ZPIPE when building for MinGW

Ángel González ingenit at zoho.com
Tue Oct 23 12:43:28 PDT 2012


On 23/10/12 15:07, Jon TURNEY wrote:
> On 22/10/2012 20:48, Ángel González wrote:
>> On 22/10/12 17:07, Jon TURNEY wrote:
>>> Define NO_ZPIPE when building for MinGW, decompressing via a pipe isn't possible
>>>
>>> Signed-off-by:  Jon TURNEY <jon.turney at dronecode.org.uk>
>>
>> This seems a bit strong statement. There's no reason for decompression
>> via pipe not to work under Windows. You only need to be careful to do
>> that using a binary stream, plus xpmPipeThrough needing a windows
>> implementation, since it is currently fork()-based.
> 
> I shall change the comment from "isn't possible" to "isn't implemented" :-)

That's probably more accurate.
I could probably implement it in a couple of hours, but there's little
incentive to do it so far without with no usage. (and CreateProcess is
quite ugly...)




More information about the xorg-devel mailing list