[PATCH] xf86: Fix non-PCI configuration-less setups

[Thierry Reding]

On Tue, Oct 16, 2012 at 01:39:06PM -0400, Adam Jackson wrote:
> On 10/15/12 6:07 AM, Thierry Reding wrote:
> >For non-PCI video devices, such as those found on many ARM embedded
> >systems, the X server currently requires the BusID option to specify the
> >full path to the DRM device's sysfs node in order to properly match it
> >against the probed platform devices.
> >
> >In order to allow X to start up properly if either the BusID option was
> >omitted or no configuration is present at all, the first video device is
> >used by default.
> >
> >Signed-off-by: Thierry Reding <thierry.reding at avionic-design.de>
> 
> Reviewed-by: Adam Jackson <ajax at redhat.com>

In retrospect I think the check could be enhanced with some safety
checks, like xf86_num_platform_devices > 0 && numDevs > 0. Otherwise
this will actually crash if no platform devices are present in the
system, which could happen if the corresponding driver wasn't loaded.

I'll prepare another patch and will resend. Thanks for reviewing!

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20121016/02eff6d8/attachment.pgp>