[PATCH] Use new pixman_glyph_cache_t API that will be in pixman 0.28.0

Keith Packard keithp at keithp.com
Sat Oct 6 21:44:45 PDT 2012


Søren Sandmann <sandmann at cs.au.dk> writes:


> diff --git a/fb/fbscreen.c b/fb/fbscreen.c
> index 7c7d656..f9080a4 100644
> --- a/fb/fbscreen.c
> +++ b/fb/fbscreen.c
> @@ -32,6 +32,7 @@ fbCloseScreen(ScreenPtr pScreen)
>      int d;
>      DepthPtr depths = pScreen->allowedDepths;
>  
> +    fbDestroyGlyphCache();
>      for (d = 0; d < pScreen->numDepths; d++)
>          free(depths[d].vids);
>      free(depths);

You got me there for a second -- you'll destroy the glyph cache every
time a screen gets closed, which (now) happens on hot un-plug.

But, it's all OK -- the glyph cache will be re-created the next time
glyphs are painted, and anything else would be a whole lot more trouble
to track.

Reviewed-by: Keith Packard <keithp at keithp.com>

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20121006/2e9e4c94/attachment.pgp>


More information about the xorg-devel mailing list