[PATCH 2/6] dbe: Cleanup in CloseScreen hook not ext CloseDown

Mark Kettenis mark.kettenis at xs4all.nl
Wed Nov 7 01:02:01 PST 2012


> From: Daniel Stone <daniel at fooishbar.org>
> Date: Wed,  7 Nov 2012 17:58:19 +1100
> 
> From: Robert Bragg <robert at linux.intel.com>
> 
> Instead of registering an extension CloseDownProc when adding the dbe
> extension this patch hooks into pScreen->CloseScreen so that the chain
> of pScreen->DestroyWindow hooks remains valid until all windows have
> been destroyed. Previously it was possible for DbeResetProc to be called
> before the root window had been destroyed and the unwrapping of
> pScreen->DestroyWindow would clobber the chain of callbacks.
> 
> This is needed for xwayland to be able to know when the root window is
> destroyed so it can unredirect root sub-windows.
> ---
>  dbe/dbe.c       |   43 ++++++++++++++++++++++---------------------
>  dbe/dbestruct.h |    1 +
>  2 files changed, 23 insertions(+), 21 deletions(-)
> 
> diff --git a/dbe/dbe.c b/dbe/dbe.c
> index 9039d80..379feb1 100644
> --- a/dbe/dbe.c
> +++ b/dbe/dbe.c
> @@ -468,7 +468,7 @@ ProcDbeSwapBuffers(ClientPtr client)
>          return BadAlloc;
>  
>      /* Get to the swap info appended to the end of the request. */
> -    dbeSwapInfo = (xDbeSwapInfo *) &stuff[1];
> +    dbeSwapInfo = (xDbeSwapInfo *) & stuff[1];

This bit seems to be a step backwards coding-style wise.


More information about the xorg-devel mailing list