[PATCH] Fix FP1616 macro

Keith Packard keithp at keithp.com
Mon Nov 5 09:01:01 PST 2012


Daniel Martin <consume.noise at gmail.com> writes:

> The macro is used with frac != 0 in to places, only. Maybe that's why
> nobody noticed that mistake before:

Yeah, except the fraction really is a fraction -- it's a floating point
value between 0 and 1.

Changing this to an inline function that declares the type of the second
arg as 'float' would make this clear.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20121105/5f64d3aa/attachment.pgp>


More information about the xorg-devel mailing list