[PATCH] xf86/modes: Defang stale pointers when copying modes

[Keith Packard]

Chris Wilson <chris at chris-wilson.co.uk> writes:

> On Wed, 30 May 2012 14:25:40 -0700, Keith Packard <keithp at keithp.com> wrote:
>> Chris Wilson <chris at chris-wilson.co.uk> writes:
>> 
>> > +extern _X_EXPORT void
>> > +xf86InternMode(DisplayModePtr intern, const DisplayModeRec * pMode);
>> 
>> The name doesn't seem very descriptive to me -- what is 'Intern'
>> supposed to mean?
>
> xf86InternalizeMode? xf86InitModeFromCopy? xf86CopyModeToStatic?

xf86SaveModeContents? (s/Contents/something-more-descriptive/?)

>> What should be done with ->Private? If this mode was ever actually handed
>> to a driver, it might not be NULL...
>
> /* And drop the backend's privates. */
> intern->PrivSize = 0;
> intern->PrivFlags = 0;
> intern->Private = 0;

Yeah, I don't think there's anything more useful to be done here.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20120531/f63a70d6/attachment.pgp>