[PULL: xserver] dri2: Add DRI2GetParam request

Chad Versace chad.versace at linux.intel.com
Tue May 29 11:34:16 PDT 2012


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05/29/2012 10:34 AM, Keith Packard wrote:
> Chad Versace <chad.versace at linux.intel.com> writes:
> 
>>   dri2: Add DRI2GetParam request (2012-05-21 14:38:05 -0700)
> 
> I don't see any default setting for ds->GetParam; it looks like older
> drivers will just crash?
> 

You're right.

All the other DRI2 functions fall back to some default behavior if
ds->DRI2Whatever is null. I've updated my patch to fall back to this:
   *is_param_recognized = FALSE;
   return Success;

After the change, I verified the build, but, since the change was so small,
did not rerun tests.

What is the correct next action? Do I need to resubmit patches or pull request?

- ----
Chad Versace
chad.versace at linux.intel.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJPxRakAAoJEAIvNt057x8iHxcQAJvIzoEwQ04smdzvplNBBO+o
F0b35JFFLEdrjNGOT/ZZhdVSLI0Wv+up16pjx0HgNKOJtt/q6L6qiUZJT7jeraJh
uFHEDr6IkAX83o62KRGqjsXczdAM3R+oEFuxJn4vRB3isedXZlKUKkSzibVOrf0J
/jQ2kqypYWRkeqpfG0HFeYAIQZhtILANXijMoQRyx+yn4veEbkMuoIowT/36XUVG
sIXaYGBYSPFdphjiwNwIJ6Ww1/Psqya5f5Yi+lGhFjMUIjdQicA2UaRS9NE9crUX
UJmAnNlrEObue9uX1VwGKZ/vX2XlLBTH3VO4r4JDyPXW4B3BKCfPIwsNd5N3iEMr
eBXHIyLXSbXSeEfxoKvbNZMQUrhRxri1BZYKLSHS1D2pkj35l5YSSIf9/p5Gkdni
8GGGsjW11FAE4rvgWY2LBwdS85zkp0Emfs/wKj+9uVQAQf7go66eP6QzEL1X4O9D
MCWHnAInyN5g+7TbkcUxQHwWe8obA3JdXx3rZGkbKhRMZ27UqsfdBFyObQNEi1Tx
WCfkiaJFk/cjzqJxo0X8vkKlCRpAPVHUflnal+Ljt6kmL4cNS9DK+uzrQ37RjdIu
ajuqWR5DlhgJDfa2wRXPp+g3BRNBK/UnGhSctbw9bao838YDZKdhY9XxENDg+W6e
YajFGK/aR35t8ufupcfO
=eQu5
-----END PGP SIGNATURE-----


More information about the xorg-devel mailing list