[PATCH 1/2 xorg-gtest] Add comment to Makefile-xorg-gtest.am about compiling with -w

Peter Hutterer peter.hutterer at who-t.net
Sun May 20 14:53:23 PDT 2012


On Fri, May 18, 2012 at 01:23:31PM -0700, Chase Douglas wrote:
> Users of xorg-gtest will not want warnings or failed builds due to
> issues in gtest or xorg-gtest.
> 
> Note that the internal build of the xorg-gtest example does not use the
> -w flag when building examples, so we will still see warnings when
> xorg-gtest itself is built.
> 
> Signed-off-by: Chase Douglas <chase.douglas at canonical.com>
> ---
>  src/Makefile-xorg-gtest.am |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/Makefile-xorg-gtest.am b/src/Makefile-xorg-gtest.am
> index 185381d..20983eb 100644
> --- a/src/Makefile-xorg-gtest.am
> +++ b/src/Makefile-xorg-gtest.am
> @@ -26,6 +26,9 @@ XORG_GTEST_BUILD_LIBS = \
>  	libxorg-gtest.a \
>  	libxorg-gtest_main.a
>  
> +# Here and below we compile without warnings (-w) because the projects using
> +# xorg-gtest will not want to see warnings or fail to build due to warnings in
> +# gtest or xorg-gtest.
>  nodist_libgtest_a_SOURCES = $(GTEST_SOURCE)/src/gtest-all.cc
>  libgtest_a_CPPFLAGS = $(GTEST_CPPFLAGS) $(AM_CPPFLAGS) -w
>  libgtest_a_CXXFLAGS = $(GTEST_CXXFLAGS) $(AM_CXXFLAGS)
> -- 
> 1.7.9.5

Reviewed-by: Peter Hutterer <peter.hutterer at who-t.net>

Cheers,
  Peter


More information about the xorg-devel mailing list