[PULL libxkbcommon] Some more fixes and minor enhancements
Ran Benita
ran234 at gmail.com
Sun May 20 11:06:01 PDT 2012
On Wed, May 09, 2012 at 12:10:57PM -0400, Kristian Høgsberg wrote:
> Hi Ran,
Hi.
> Let me just point you to this branch as well:
>
> http://cgit.freedesktop.org/~krh/libxkbcommon/log/?h=keysyms
>
> I've been talking with Daniel about this in IRC, but I thought you
> might want to take a look too. With those patches the API is
> completely self-contained. We still need xproto, kbproto and
> Xfuncproto at compile time, but none of that leaks through the
> exported API.
This is very nice, thanks. I only have a couple of suggestions, please
see the following patches.
Also, might be worth mentioning that we now define both XKB_KEY_UP and
XKB_KEY_Up (down as well): one for enum xkb_key_direction and one for
the keysym. I don't see much room for confusion, though.
More information about the xorg-devel
mailing list