[PATCH v3 00/02] dri2: Add DRI2GetParam request

Chad Versace chad.versace at linux.intel.com
Wed May 16 12:44:39 PDT 2012


(Resending. I accidentally sent this to xorg rather than xorg-devel).

This series extends the DRI2 protocol by adding a new request, DRI2GetParam.
The new request effectively allows clients to perform feature detection on the
DDX.

When Intel begins adding MSAA support to its DDX, having a clean way to do
feature detection will allow us to avoid painful painful feature-detection
hacks.

I have written several functional tests in Piglit for this series. All tests
pass. You can find the tests at piglit:tests/dri2/dri2-getparam*.c. To run
the tests, you need the dri2getparam branch in the following repos:
    git://people.freedesktop.org/~chadversary/xorg.proto.dri2proto.git
                                             /xorg.xserver.git
                                             /xorg.driver.xf86-video-intel.git
                                             /xcb.proto.git
                                             /xcb.libxcb.git
                                             /piglit.git


The series touches both dri2proto and the xserver.

v2:
    - Fixed typo "param_is", per anholt.
    - Changed param from CARD64 to CARD32, per krh and anholt.
    - Removed namespaces, per krh. Instead, there is an enum range reserved
      for each the server and the ddx.
    - Updated Piglit tests and verified that tests still pass.

v3:
    - Moved 'is_param_recognized' into an unused byte in the packet header,
      per Alan.
    - Clarified, in protocol documentation, that 1) there are no server
      parameters defined yet and but that they will be defined in the
      dri2proto headers; and that 2) driver parameters are private to each driver
      and are defined by the respective driver's headers.
    - Fixed typos, per Alan.
    - Verified that tests still pass.

Chad Versace (2):
  [dri2proto] dri2proto: Add DRI2GetParam request
  [xserver]   dri2: Add DRI2GetParam request


More information about the xorg-devel mailing list