[PATCH xorg-gtest] examples: built tests as noinst_PROGRAMS

Chase Douglas chase.douglas at canonical.com
Tue May 15 16:59:04 PDT 2012


On 05/15/2012 04:08 PM, Peter Hutterer wrote:
> check_PROGRAMS is only built on make check, so it's a good way of
> introducing build errors until later (as we discovered in the server).
> Always built the tests, running them is optional.
> 
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> ---
>  examples/Makefile.am |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/examples/Makefile.am b/examples/Makefile.am
> index 5c41732..b9b914b 100644
> --- a/examples/Makefile.am
> +++ b/examples/Makefile.am
> @@ -48,10 +48,10 @@ libxorg_gtest_main_a_CPPFLAGS = \
>  	-I$(top_srcdir)
>  libxorg_gtest_main_a_CXXFLAGS = $(GTEST_CXXFLAGS) $(AM_CXXFLAGS)
>  
> -check_PROGRAMS = xorg-gtest-example
> +noinst_PROGRAMS = xorg-gtest-example
>  
>  if ENABLE_XORG_GTEST_TESTS
> -TESTS = $(check_PROGRAMS)
> +TESTS = $(noinst_PROGRAMS)
>  endif
>  
>  xorg_gtest_example_SOURCES = xorg-gtest-example.cpp

I'm surprised that's not how I have it already :).

Reviewed-by: Chase Douglas <chase.douglas at canonical.com>


More information about the xorg-devel mailing list