[PATCH] int10/vbe: don't use xf86Screens. (ABI) (v2)

Adam Jackson ajax at nwnk.net
Tue May 15 14:08:25 PDT 2012


On 5/15/12 2:52 PM, Dave Airlie wrote:
> Pass the ScrnInfoPtr instead of the index in the int10 struct.

Mostly good, but...

> @@ -340,7 +341,7 @@ vbeDoEDID(vbeInfoPtr pVbe, pointer pDDCModule)
>       if (!DDC_data)
>           return NULL;
>
> -    pMonitor = xf86InterpretEDID(pVbe->pInt10->scrnIndex, DDC_data);
> +    pMonitor = xf86InterpretEDID(pVbe->pInt10->pScrn->scrnIndex, DDC_data);

The callee here wants index->ptr conversion too, doesn't it?  I don't 
think I see that in subsequent patches.

- ajax


More information about the xorg-devel mailing list