[PATCH 14/19] int10: cleanup one unnecessary use of xf86Screens

Adam Jackson ajax at nwnk.net
Tue May 15 14:03:48 PDT 2012


On 5/14/12 12:41 PM, Dave Airlie wrote:
> Signed-off-by: Dave Airlie <airlied at redhat.com>

Ack, though...

> diff --git a/hw/xfree86/int10/generic.c b/hw/xfree86/int10/generic.c
> index 8614e0b..4b97520 100644
> --- a/hw/xfree86/int10/generic.c
> +++ b/hw/xfree86/int10/generic.c
> @@ -70,12 +70,12 @@ xf86ExtendedInitInt10(int entityIndex, int Flags)

That type signature is going to make it weird-to-impossible to use int10 
on non-hotplug-capable drivers, I suspect.  I believe it was Kierkegaard 
who said "whatever".  I guess you'd want to pass EntityPtr instead of 
entityIndex if you felt like cleaning it up, but seriously go away int10.

- ajax


More information about the xorg-devel mailing list