[PATCH] xfree86: use udev to provide device enumeration for kms devices (v4
Adam Jackson
ajax at nwnk.net
Tue May 15 12:36:46 PDT 2012
On 5/14/12 3:42 AM, Dave Airlie wrote:
> +struct xf86_platform_device;
>
> typedef struct _DriverRec {
> int driverVersion;
> @@ -325,9 +326,20 @@ typedef struct _DriverRec {
> const struct pci_id_match *supported_devices;
> Bool (*PciProbe) (struct _DriverRec * drv, int entity_num,
> struct pci_device * dev, intptr_t match_data);
> +#ifdef XSERVER_PLATFORM_BUS
> + Bool (*platformProbe) (struct _DriverRec * drv, int entity_num, int flags,
> + struct xf86_platform_device * dev, intptr_t match_data);
> +#else
> + void *platformProbe; /* place holder to non udev-kms support so struct is right size */
> +#endif
> } DriverRec, *DriverPtr;
Style point: I don't think there's any reason to make this conditional.
You've already got the opaque struct decl for xf86_platform_device.
Looks alright to me otherwise.
Reviewd-by: Adam Jackson <ajax at redhat.com>
- ajax
More information about the xorg-devel
mailing list