[PATCH 0/4] BUG_RETURN_VAL macros
Mark Kettenis
mark.kettenis at xs4all.nl
Tue May 15 11:06:48 PDT 2012
> From: Peter Hutterer <peter.hutterer at who-t.net>
> Date: Tue, 15 May 2012 20:26:37 +1000
>
> I got annoyed having to write constructs like
>
> BUG_WARN(foo);
> if (foo)
> return FALSE;
>
> and similar. glib has useful macros like g_return_if_fail and similar, these
> are macros that essentially do the same job. They shout into the log, but
> otherwise continue as normal.
>
> http://developer.gnome.org/glib/2.29/glib-Warnings-and-Assertions.html#g-return-if-fail
>
> These are not macros that should be used for handling normal out-of-scope
> values, they're there to shout that there is a real bug that needs fixing.
Still I think I agree with whoever said that hiding control flow
instructions behind a macro isn't a good idea.
More information about the xorg-devel
mailing list