[PATCH 1/4] xf86/modes: drop two uses of screenInfo

Dave Airlie airlied at gmail.com
Tue May 15 09:56:33 PDT 2012


On Tue, May 15, 2012 at 4:16 PM, Keith Packard <keithp at keithp.com> wrote:
> On Mon, 14 May 2012 13:00:20 +0100, Dave Airlie <airlied at gmail.com> wrote:
>
>> -    /* if this is called during ScreenInit() we don't have pScrn->pScreen yet */
>> -    ScreenPtr pScreen = screenInfo.screens[pScrn->scrnIndex];
>> +    ScreenPtr pScreen = xf86ScrnToScreen(pScrn);
>
> I assume your fine new macro doesn't have a problem with pScrn->pScreen
> not being set yet?

Well currently they just do lookups in the global arrays in a
function, so we don't have to worry,

I'd plan on embedding ScreenRec into ScrnInfoRec at some point in the
distant future,
then the accessor can just be a cast, but it needs a bit more work
that I don't want to get bogged down in now.

Dave.


More information about the xorg-devel mailing list