[PATCH] os: Add CryptoAPI as a choice of SHA1 implementation

Jon TURNEY jon.turney at dronecode.org.uk
Tue May 1 08:42:44 PDT 2012


On 26/04/2012 08:11, Yaakov (Cygwin/X) wrote:
> From: Yaakov Selkowitz <yselkowitz-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f at public.gmane.org>
> 
> Both Cygwin and MinGW can use Windows' native CryptoAPI for SHA1,
> saving a dependency on libgcrypt or OpenSSL.  The necessary functions
> are in ADVAPI32.DLL, which is among the default lib flags and is
> already used in hw/xwin for accessing the registry.
> 
> Signed-off-by: Yaakov Selkowitz <yselkowitz-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f at public.gmane.org>
> ---
> Jon, Ryan, any thoughts on this?  From experience, you can tell if you mess
> this up because character rendering in GTK+ depends on it.  This would
> allow us to drop the libgcrypt dep, although I haven't tried to compare
> performance between the implementations.

This looks correct and useful when building for MinGW, so:

Reviewed-by: Jon TURNEY <jon.turney at dronecode.org.uk>




More information about the xorg-devel mailing list