[PATCH xserver 2/2] xfree86: add support for Cygwin

[Alan Coopersmith]

On 03/28/12 11:33 PM, Mark Kettenis wrote:
>> Date: Wed, 28 Mar 2012 23:05:51 -0500
>> From: "Yaakov (Cygwin/X)" <yselkowitz at users.sourceforge.net>
>>
>> On 2012-03-28 22:19, Alan Coopersmith wrote:
>>> On 03/27/12 10:16 PM, Yaakov (Cygwin/X) wrote:
>>>> +
>>>> +i2c/libi2c.la:
>>>> +	$(MAKE) -C $(@D) $(@F)
>>>> +
>>>> +dixmods/libdixmods.la:
>>>> +	$(MAKE) -C $(@D) $(@F)
>>>> +
>>>> +dixmods/libxorgxkb.la:
>>>> +	$(MAKE) -C $(@D) $(@F)
>>>
>>> Should those be $(MAKE) $(AM_MAKEFLAGS) ... ?  That's what most automake calls
>>> seem to use.
>>> Also -C is a gnu make specific flag, but I think we still require GNU make
>>> to build the server due to other issues anyway.
> 
> The server builds fine with (Open)BSD make, and we'd like to keep it
> that way.  And it doesn't support -C.

I can see the attraction of not having to fork another shell just for evaluating
"cd $(@D) ; $(MAKE) $(@F)", so we should probably work on getting it added
to our non-GNU make utilities for the future, but that doesn't help short term.

> Including "." in SUBDIRS seems like a gross hack to me as well.

It's the documented solution in the automake manual though, so hardly more
gross than automake itself:

https://www.gnu.org/software/automake/manual/html_node/Subdirectories.html#Subdirectories

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc