[PATCH] prevent X crash on pressing multimedia buttons

Jeremy Huddleston jeremyhu at apple.com
Mon Mar 26 11:31:32 PDT 2012

The "numAxes < i || ..." check seems odd (hopefully Peter can comment) ... but the rest of the logic looks sound.

Please reference the bug URL in the comment:

On Mar 26, 2012, at 7:40 AM, Michal Suchanek <hramrach at gmail.com> wrote:

> Hello,
> this is basically a backport of
> 2416ee4a015068359807a10f433e8c54192c78a9 to 1.11 branch which fixes X
> server crash on queuing pointer events on devices without axis.
> On 1.11 this is only triggered under special circumstances (eg. when
> Xscreensaver unlock dialog is active).
> It fixes the issue for me.
> I only hit the problem that valuator is NULL.
> Not sure if an event for an axis not present on a device which does
> have some axis can be queued. There are checks for that but not tested
> because such event are not generated in my setup.
> Please review
> Thanks
> Michal
> <0001-Avoid-crash-on-button-events-on-device-without-valua.patch>_______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel

More information about the xorg-devel mailing list