[PATCH 3/5] Xext: remove needless /* parameter */ comments in declaration

Peter Hutterer peter.hutterer at who-t.net
Mon Mar 12 17:41:26 PDT 2012


On Mon, Mar 12, 2012 at 05:10:39PM -0700, Alan Coopersmith wrote:
> On 03/12/12 04:20 PM, Peter Hutterer wrote:
> >+    CARD64 inital_value,
> 
> Should that be "initial"?

yes, I'll fix it up, thanks.
 
> >+    CARD64 resolution,
> >+    SyncCounterType counterType,
> >      SyncSystemCounterQueryValue QueryValue,
> >      SyncSystemCounterBracketValues BracketValues
> >  );
> >
> >  extern void SyncChangeCounter(
> >-    SyncCounter *	/* pCounter*/,
> >-    CARD64  		/* new_value */
> >+    SyncCounter *  pCounte,
> >+    CARD64  new_value
> 
> Shouldn't you just merge patch 4 with this instead of introducing a typo in
> one patch and fixing in the next?

whoops, i could've sworn the typo was there to begin with. how embarrassing.
I'll squash them together. thanks.

Cheers,
  Peter


More information about the xorg-devel mailing list