[PATCH xorg-gtest 1/3] config: remove unrequired AC_SUBST DUMMY_CONF_PATH statement

Chase Douglas chase.douglas at canonical.com
Fri Mar 9 07:15:48 PST 2012


On 03/08/2012 04:48 PM, Gaetan Nadon wrote:
> The variable is not used in any makefile. Configure.ac does not participate
> in the determination of the conf path. The final value of datadir is not
> known at config time, only at make time.
>
> Signed-off-by: Gaetan Nadon<memsize at videotron.ca>
> ---
>   configure.ac |    2 --
>   1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 51de80f..9b2dee0 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -52,8 +52,6 @@ AS_IF([test "x$with_evemu" == xyes],
>         [PKG_CHECK_MODULES(EVEMU, utouch-evemu, [have_evemu=yes], [:])])
>   AM_CONDITIONAL([HAVE_EVEMU], [test "x$have_evemu" = "xyes"])
>
> -AC_SUBST(DUMMY_CONF_PATH, "$datadir/xorg/gtest/dummy.conf")
> -
>   AC_CONFIG_FILES([Makefile
>                    xorg-gtest.pc])

I'm not sure what happened here, but this looks right.

Reviewed-by: Chase Douglas <chase.douglas at canonical.com>

And merged.


More information about the xorg-devel mailing list