[PATCH xorg-gtest 3/3] config: use existing feature --enable-strict-compilation

Gaetan Nadon memsize at videotron.ca
Thu Mar 8 14:33:21 PST 2012


This replaces current code attempting to perform similar function.
In configure.ac, the code is gcc specific.
The src/Makefile.am has $(WARNING_FLAGS) rather than $(WARNING_CPPFLAGS)

http://cgit.freedesktop.org/xorg/util/macros/tree/xorg-macros.m4.in

Looking at the xorg-gtest module --help text:
  --enable-strict-compilation
                          Enable all warnings from compiler and make them
                          errors (default: disabled)

Signed-off-by: Gaetan Nadon <memsize at videotron.ca>
---

	There are always different opinions when it comes to warnings vs errors,
	this patch proposes what has become a consensus in xorg over the years.

 configure.ac    |    2 --
 src/Makefile.am |    2 --
 2 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/configure.ac b/configure.ac
index bd8e2c0..51de80f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -57,8 +57,6 @@ AC_SUBST(DUMMY_CONF_PATH, "$datadir/xorg/gtest/dummy.conf")
 AC_CONFIG_FILES([Makefile
                  xorg-gtest.pc])
                 
-AC_SUBST(WARNING_CPPFLAGS, "-Wall -Werror")
-
 AC_CONFIG_FILES([data/Makefile
                  doc/Makefile
                  examples/Makefile
diff --git a/src/Makefile.am b/src/Makefile.am
index a75fb9e..772e257 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -25,8 +25,6 @@
 
 lib_LTLIBRARIES = libxorg-gtest.la libxorg-gtest_main.la
 
-AM_CPPFLAGS = $(WARNING_FLAGS)
-
 AM_CXXFLAGS = -I$(top_srcdir)/include $(XSERVER_CFLAGS) $(BASE_CXXFLAGS)
 
 libxorg_gtest_la_SOURCES = \
-- 
1.7.5.4



More information about the xorg-devel mailing list