[PATCH xf86-input-synaptics v4 04/10] Add cumulative_d{x, y} to SynapticsHwState

[Matthew Monaco]

On 03/02/2012 01:42 PM, Chase Douglas wrote:
> These values will be used for clickpad press and drag with two fingers.
>
> While the clickpad button is not pressed, cumulative_d{x,y} will match x
> and y values. Once the clickpad button is pressed, cumulative_d{x,y}
> will be updated with the relative motion of each active touch on the
> touchpad. This allows for dragging with one finger while another finger
> stays stationary holding the clickpad button down.
>
> This is an easier and less latent approach than trying to guess which
> touch was the "dragging" touch.
>
> Signed-off-by: Chase Douglas <chase.douglas at canonical.com>
> Reviewed-by: Peter Hutterer <peter.hutterer at who-t.net>
> ---
>  src/eventcomm.c     |   35 +++++++++++++++++++++++++++++++++--
>  src/synproto.c      |    2 ++
>  src/synproto.h      |    2 ++
>  test/fake-symbols.c |    5 +++++
>  4 files changed, 42 insertions(+), 2 deletions(-)
>
> diff --git a/src/eventcomm.c b/src/eventcomm.c
> index 60be6fe..a1f334b 100644
> --- a/src/eventcomm.c
> +++ b/src/eventcomm.c
> @@ -526,6 +526,18 @@ SynapticsReadEvent(InputInfoPtr pInfo, struct input_event
*ev)
>      return rc;
>  }
>
> +static Bool
> +EventTouchSlotPreviouslyOpen(SynapticsPrivate *priv, int slot)
> +{
> +    int i;
> +
> +    for (i = 0; i < priv->num_active_touches; i++)
> +        if (priv->open_slots[i] == slot)
> +            return TRUE;
> +
> +    return FALSE;
> +}


Should this be wrapped in HAVE_MTDEV (or HAVE_MULTITOUCH)?