[PATCH 1/1] Look for ModuleData only in appropriate library

Daniel Stone daniel at fooishbar.org
Wed Jun 27 10:01:55 PDT 2012


On 27 June 2012 17:04, Michal Srb <msrb at suse.com> wrote:
> +void *
> +LoaderSymbolFromModule(const char *name, void *handle)
> +{
> +    return dlsym(handle, name);
> +}

As a nitpick, I'd expect this to be LoaderSymbolFromModule(handle,
name) - and had wrote this even before I noticed that dlsym had the
arguments that way around too.  It just seems like a more logical

That aside:
Reviewed-by: Daniel Stone <daniel at fooishbar.org>


More information about the xorg-devel mailing list