[PATCH 1/4] shadowfb calls GetGlyphs() so list libXfont as a dependency

[Alan Coopersmith]

On 06/21/12 07:03 PM, Yaakov (Cygwin/X) wrote:
> On 2012-06-21 19:52, Alan Coopersmith wrote:
>> diff --git a/configure.ac b/configure.ac
>> index fb3d120..7047d97 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -813,9 +813,10 @@ LIBSELINUX="libselinux >= 2.0.86"
>>   LIBDBUS="dbus-1 >= 1.0"
>>   LIBPIXMAN="pixman-1 >= 0.21.8"
>>
>> -dnl Pixman is always required, but we separate it out so we can link
>> -dnl specific modules against it
>> +dnl Pixman & libXfont are always required, but we separate them out so we can
>> +dnl link specific modules against them
>>   PKG_CHECK_MODULES(PIXMAN, $LIBPIXMAN)
>> +PKG_CHECK_MODULES(XFONT, $LIBXFONT)
>>   REQUIRED_LIBS="$REQUIRED_LIBS $LIBPIXMAN $LIBXFONT xau"
>>
>>   dnl Core modules for most extensions, et al.
>> diff --git a/hw/xfree86/shadowfb/Makefile.am b/hw/xfree86/shadowfb/Makefile.am
>> index 5756fca..4a2cbff 100644
>> --- a/hw/xfree86/shadowfb/Makefile.am
>> +++ b/hw/xfree86/shadowfb/Makefile.am
>> @@ -1,7 +1,7 @@
>>   module_LTLIBRARIES = libshadowfb.la
>>   libshadowfb_la_LDFLAGS = -module -avoid-version $(LD_NO_UNDEFINED_FLAG)
>>   libshadowfb_la_SOURCES = sfbmodule.c shadow.c
>> -libshadowfb_la_LIBADD = $(PIXMAN_LIBS)
>> +libshadowfb_la_LIBADD = $(PIXMAN_LIBS) $(XFONT_LIBS)
> 
> This is a problem for Cygwin, as we are forced to use a static libXfont due to
> limitations in weak symbol linkage; the libXfont symbols end up exported from
> Xorg itself.  Since libtool will not allow linking a shared library against a
> static one, we'll end up with a static shadowfb module, which obviously won't be
> very useful.

Blargh.   On Solaris you have to link libXfont just right to avoid the weak
symbols being linked wrong and overriding the symbols from Xorg, which leaves
Xorg unable to start because it can't even find the builtin fonts.   Maybe
its time to finally make libXfont stop being a 900 lb. weakling.


-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc