[PATCH 3/4] Fix dtrace hook special object generation

Alan Coopersmith alan.coopersmith at oracle.com
Wed Jun 20 21:17:05 PDT 2012


Sorry, but I tried a bunch of stuff before finally remembering why it is I had
to do it this way - the ELF magic for dtrace probes on Solaris gets lost
building static libraries, so we lose all the probes when you convert to *.la
files.    Maybe we can find some other way around this, but since this patch
completely kills the Dtrace probes on Solaris, I'm going to say "Nack" for it's
current form.

Perhaps we can isolate the .la avoidance to just Solaris and leave Linux & MacOS
using .la's for these?

	-alan-

On 06/17/12 08:40 PM, Peter Hutterer wrote:
> With --disable-xorg, We also disabled a bunch of tests because of their
> perceived reliance on a DDX. The cause was libtool missing some object files
> that never ended up in libxservertest.la. Only the xfree86 test has a true
> dependency on XORG.
> 
> DIX_LIB was pointing to dix.O (instead of libdix.la) when
> DTRACE_SPECIAL_OBJECTS was defined. libdix.la should be part of XSERVER_LIBS
> but dix.O is not a recognised libtool object, so it got skipped for
> libxservertest.a. Only in the XORG case would we add DIX_LIB and OS_LIB
> manually, thus forcing linkage with the dtrace-generated objects.
> 
> Fix this by packaging up the dtrace-generated files as part of
> libdix.la/libos.la.
> 
> Hilarity included to auto-create the source file (so automake will trigger
> the hook) and calling libtool --mode=compile so it'll recognise the
> dtrace-generated object files and package, suggestions welcome.
> 
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc


More information about the xorg-devel mailing list