[PATCH 2/2] mi: Log an error if mieqProcessInputEvents() recurses.

Keith Packard keithp at keithp.com
Fri Jun 15 16:45:15 PDT 2012

Andy Ritger <aritger at nvidia.com> writes:

> Also, remove the unnecessary static qualifier on mieqProcessInputEvents()'s
> 'event' local variable.

following the 'each patch does one thing' rule, this should probably be
split out. In any case, I reviewed where this code came from, and a
static qualifier is not necessary -- the code used to need to deal with
events that could change sizes, and so mieqProcessInputEvents had a
static pointer to storage that got resized as needed; a useful
optimization, but not necessary.

In any case, for this hunk,

Reviewed-by: Keith Packard <keithp at keithp.com>

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20120615/9155a582/attachment.pgp>

More information about the xorg-devel mailing list