[PATCH 1/3] OtherClientGone: Remove unreachable return statement

Keith Packard keithp at keithp.com
Fri Jun 15 15:58:27 PDT 2012


Alan Coopersmith <alan.coopersmith at oracle.com> writes:

> Now that FatalError is marked as _X_NORETURN, the compilers know we
> can't get here, and the return statement added to make them happy in
> the past now makes them unhappy.
>
> Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
> ---
>  dix/events.c |    1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/dix/events.c b/dix/events.c
> index 83ae5c9..069888b 100644
> --- a/dix/events.c
> +++ b/dix/events.c
> @@ -4313,7 +4313,6 @@ OtherClientGone(pointer value, XID id)
>          prev = other;
>      }
>      FatalError("client not on event list");
> -     /*NOTREACHED*/ return -1;  /* make compiler happy */

Always nice to clean things up.

Reviewed-by: Keith Packard <keithp at keithp.com>

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20120615/f474f32f/attachment.pgp>


More information about the xorg-devel mailing list