[PATCH xf86-video-nested] Fix return check of XShmQueryExtension
Jeremy Huddleston
jeremyhu at apple.com
Fri Jun 15 00:32:59 PDT 2012
Well, I guess that means the !SHM path was tested as working now =)
Thanks,
Jeremy
a438098..ad48dc6 master -> master
On Jun 13, 2012, at 12:40 AM, Daniel Martin <daniel.martin at secunet.com> wrote:
> Hi,
>
> here's a small patch, just one character ...
>
> greetings, Daniel
>
> ---8<---
>
> XShmQueryExtension returns true if it is supported. Due to a missing "!"
> within the if clause the assumption was that there is no MIT-SHM even if
> it was.
> ---
> src/xlibclient.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/xlibclient.c b/src/xlibclient.c
> index f58106a..1aa3590 100644
> --- a/src/xlibclient.c
> +++ b/src/xlibclient.c
> @@ -100,7 +100,7 @@ NestedClientTryXShm(NestedClientPrivatePtr pPriv, int scrnIndex, int width, int
> int shmMajor, shmMinor;
> Bool hasSharedPixmaps;
>
> - if (XShmQueryExtension(pPriv->display)) {
> + if (!XShmQueryExtension(pPriv->display)) {
> xf86DrvMsg(scrnIndex, X_INFO, "XShmQueryExtension failed. Dropping XShm support.\n");
>
> return FALSE;
> --
> 1.7.5.4
>
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
>
More information about the xorg-devel
mailing list