[PATCH v2] Xmd.h: Treat __ILP32__ targets as LONG32 ones

Lu, Hongjiu hongjiu.lu at intel.com
Mon Jun 11 06:04:20 PDT 2012

> On Sun, 10 Jun 2012 18:10:56 +0000, "Lu, Hongjiu" <hongjiu.lu at intel.com>
> wrote:
> > > This patch is proof that redefining __amd64__ breaks existing
> software,
> > > forcing us to go around adding new changes to avoid damage.    It's
> not
> > > adding the __ILP32__ check that breaks things, it's forcing all the
> > > existing software to add it that is the breakage.
> > >
> >
> > That is false.  You still don't show adding __ILP32__ check will
> > break anything.
> Adding new symbols does not break anything. But changing existing
> symbols to
> have a different meaning does. That's the whole point here.
> Until now we assumed that __amd64__ has a certain meaning. You changed
> it. And
> so now everybody and their grandmother have to go and update their
> source. Do
> you want to guess how many thousands software packages you're going to
> break?

If a software checks __amd64__, it is likely that it won't compile
correctly for -mx32, no matter if -mx32 defines __amd64__ or not.
In this senses, this software is broken for -mx32.  Yes, this package
needs updates to support -mx32.  However, adding __ILP32__ check
to this package won't break anything.


More information about the xorg-devel mailing list