[PATCH] Change autogen.sh scripts to respect NOCONFIGURE

Gaetan Nadon memsize at videotron.ca
Sat Jun 9 14:26:46 PDT 2012

On 12-06-08 04:59 PM, Colin Walters wrote:
> On Fri, 2012-01-06 at 10:18 -0500, Gaetan Nadon wrote:
>> The latest thought is to have the util-macros package version check in
>> the copy of autogen.sh in each module. This should not make it any more
>> unpleasant than the current situation.
>> Having read your comment, I would not make the XORG_MACROS_VERSION(1.17)
>> change. In this transition period, older modules can be built with
>> autoreconf & configure from git using a <= 1.16 xorg-macros.
>> From a single module developer point of view, the autogen.sh is not
>> needed to build from source. It's not part of the GNU build system
>> architecture. It's a legacy script from the days where autoreconf did
>> not exist and a handful of commands had to be submitted every time.
> So, a few months later...any further thoughts on this?  Anything I can
> do to help?
> I know it's a trivial thing, but I've made a lot of progress in
> standardizing the build-from-git across many modules in the stack now,
> and X.org definitely stands out in sheer module count =)

I have kept thinking about it since then. The changes to the script are
ok, but if the whole point of installing a copy through util-macros was
to save patch work for the future, having an "else" part defeats the
purpose. In the future, we would end up with (potentially) two different
behaviours depending if the script was installed or if the "else" part
was used.

I'd rather have a script change only and drop the "install through
util-macros" part. This will reduce the overall complexity and reduce
the number of places to investigate when things go wrong. Changes to the
script are likely to be several years apart.

If I had time to implement this project, I would have included a patch
from Roland Mainz which add quotes to support directories containing
spaces. I cannot locate the patch itself, but I wrote a note as to where
the quotes were added:

    #! /bin/sh

    srcdir=`dirname "$0"`
    test -z "$srcdir" && srcdir=.        <===

    cd "$srcdir"                <===

    autoreconf -v --install || exit 1
    cd "$ORIGDIR" || exit $?        <=====

    "$srcdir/configure" --enable-maintainer-mode "$@"    <=====

    Roland Mainz wrote:
    Note the issue mainly applies to users on Windows which use
    environments like Cygwin, UWIN, SFU etc. where user homedirs very
    often have whitespaces etc. in the name of their home directory.

A note about http://cgit.freedesktop.org/xorg/test/xorg-gtest/. This
module has a different script (the only one so far) which never runs
./configure. Chase Douglas is actively maintaining this module. The new
script you are proposing might just well be what he was waiting for.

Overall there are about 240 modules that are being published at
different intervals. The list can be obtained by running
modular/build.sh -L.

If you post the revised patch, I'll be happy to review it.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20120609/93c83c9b/attachment.html>

More information about the xorg-devel mailing list