[PATCH] Change autogen.sh scripts to respect NOCONFIGURE

Daniel Stone daniel at fooishbar.org
Fri Jun 8 15:20:05 PDT 2012


Hi,

On 5 January 2012 17:01, Colin Walters <walters at verbum.org> wrote:
> Hmm...but how many people
>
> 1) Build an xorg module from git

A fair few.  Modularisation was a huge step for us towards making
X.Org less scary: we can now say 'this should be fixed in git, can you
please pull?' to bug reporters with a straight face, and the second
step has been the new review/commit/release process which has meant
that the tree is actually usable at all times, rather than just a
random crapheap.

Anything which jeopardises that is a _serious_ step backwards.

> but can't ALSO trivially update xorg-util-macros?  I'm not too familiar
> with the workflow of people who hack on X.org related modules, so it's
> an honest question.

Having to make sure people have the very latest xorg-macros and it's
installed is a bit of a barrier to entry.

> Regardless we could certainly change the patch to all modules to be:
>
> #!/bin/sh
> common_autogen=`which xorg-util-autogen.sh 2>/dev/null`
> if test -n "$common_autogen"; then
>  exec $common_autogen "$@"
> else
>  # copy&pasted version here
> fi

Yeah, I do like this.

Gaetan is our build system maintainer (sorry Gaetan), so if you get
the changes OKed by him and the only barrier is getting him committed,
then we can definitely get you commit access to push this through.

Cheers,
Daniel


More information about the xorg-devel mailing list