[PATCH evdev 1/6] Use xf86IDrvMsg in emuMB.c instead of ErrorF

Peter Hutterer peter.hutterer at who-t.net
Thu Jun 7 04:25:41 PDT 2012


On 7/06/12 19:27 , walter harms wrote:
> I guess the message should read ?!
>
> "replacing ErrorF() with xf86IDrvMsg() to make ErrorF obsolete"

not quite, ErrorF is still the primary error logging function inside the 
server. For drivers though we have xf86IDrvMsg, which automatically logs 
the driver name and input device name, making logs a tad easier to debug.

So ErrorF isn't obsolete with this, this was just the last place we used 
it inside evdev.

Cheers,
   Peter

> Am 07.06.2012 03:36, schrieb Peter Hutterer:
>> Signed-off-by: Peter Hutterer<peter.hutterer at who-t.net>
>> ---
>>   src/emuMB.c |    4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/src/emuMB.c b/src/emuMB.c
>> index eb01495..b25eac8 100644
>> --- a/src/emuMB.c
>> +++ b/src/emuMB.c
>> @@ -196,8 +196,8 @@ EvdevMBEmuTimer(InputInfoPtr pInfo)
>>           pEvdev->emulateMB.state =
>>               stateTab[pEvdev->emulateMB.state][4][2];
>>       } else {
>> -        ErrorF("Got unexpected buttonTimer in state %d\n",
>> -                pEvdev->emulateMB.state);
>> +        xf86IDrvMsg(pInfo, X_ERROR, "Got unexpected buttonTimer in state %d\n",
>> +                    pEvdev->emulateMB.state);
>>       }
>>
>>       xf86UnblockSIGIO (sigstate);



More information about the xorg-devel mailing list