[PATCH] vbe: Fix caching of DDC support status

Adam Jackson ajax at redhat.com
Mon Jul 30 12:23:00 PDT 2012


There are multiple kinds of "not supported" here.  One of them is where
the video BIOS doesn't support the entrypoint.  Another is where the
BIOS returns nothing because no monitor happens to be connected.  In the
latter case we should just pretend we haven't checked yet, otherwise
plugging in a monitor later and retrying DDC would fail.

Signed-off-by: Adam Jackson <ajax at redhat.com>
---
 hw/xfree86/vbe/vbe.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/hw/xfree86/vbe/vbe.c b/hw/xfree86/vbe/vbe.c
index 97a9bcf..3514f80 100644
--- a/hw/xfree86/vbe/vbe.c
+++ b/hw/xfree86/vbe/vbe.c
@@ -183,8 +183,6 @@ vbeProbeDDC(vbeInfoPtr pVbe)
 
     if (pVbe->ddc == DDC_NONE)
         return FALSE;
-    if (pVbe->ddc != DDC_UNCHECKED)
-        return TRUE;
 
     pVbe->pInt10->ax = 0x4F15;
     pVbe->pInt10->bx = 0;
@@ -207,7 +205,7 @@ vbeProbeDDC(vbeInfoPtr pVbe)
         switch (pVbe->pInt10->bx & 0x3) {
         case 0:
             ddc_level = " none";
-            pVbe->ddc = DDC_NONE;
+            pVbe->ddc = DDC_UNCHECKED;
             break;
         case 1:
             ddc_level = " 1";
-- 
1.7.7.6



More information about the xorg-devel mailing list