[PATCH xserver 0/2] glx/dri2: Fix bug #50019.

[Jeremy Huddleston Sequoia]

On Jul 30, 2012, at 07:03, Michel Dänzer <michel at daenzer.net> wrote:

>> I agree that it's very unlikely that anyone would mix libglx.so and
>> libdri2.so between versions, and yes of course making the symbol not
>> exported would cause libglx.so to not be able to use it.
> 
> And you do realize the fix requires libglx.so to use it? :)

Yes, I may have been on vacation for a month, but not *everything* has been paged out ;)

>> The issue I'm concerned with is whether DRI2CreateDrawable2 will
>> *only* be used by co-shipping code (ie code living in xserver like
>> libglx.so) or if drivers (esp 3rd party binary-only drivers) might
>> start using it directly.
> 
> According to Keith, there are no external users of DRI2CreateDrawable
> after almost 4.5 years.

Ok.

>> That will get us into a situation where some servers advertising the
>> same ABI version have DRI2CreateDrawable2 and some don't.
> 
> You could bump the ABI minor version.
> 
> Or you could use the fix I posted originally, which doesn't involve new
> symbols (but comes with obvious risks).
> 
> 
> Whatever you do, please don't leave 1.12 users prone to this annoying
> bug.

Ok.  I think that letting DRI destroy the GLX drawable is just all kinds of ugly from the layering perspective.  Now the server isn't the most beautifully layered collection of code out there, but we've been making great strides in "the right direction", so I'd like to keep it that way.

I think an ABI minor bump would be the safest solution.

Would you mind sending me a [PULL]?

Thanks,
Jeremy