[PATCH 2/4] Do not report the GLX_INTEL_swap_event extension for indirect swrast

[Jeremy Huddleston Sequoia]

Reviewed-by: Jeremy Huddleston Sequoia <jeremyhu at apple.com>

On Jul 20, 2012, at 05:54, Jon TURNEY <jon.turney at dronecode.org.uk> wrote:

> Commit 84956ca4 bogusly adds GLX_INTEL_swap_event to the extensions reported
> by swrast.
> 
> "DRI2 supports this now - and already enables it explicitly - but drisw does
> not and should not. Otherwise toolkits like clutter will only ever SwapBuffers
> once and wait forever for an event that's not coming."
> 
> (A similar bug for direct swrast is already fixed in mesa commit 25620eb1)
> 
> (Note that this may be papering over the cracks somewhat, as if we do report
> GLX_INTEL_swap_event, some clutter apps fail with GLXBadDrawable calling
> GLXChangeDrawableAttributes to change the setting of GLX_BUFFER_SWAP_COMPLETE_INTEL_MASK
> in the GLX_EVENT_MASK, apparently after the drawable is destroyed, which suggests
> a bug with GLXDrawable lifetimes)
> 
> Signed-off-by: Jon TURNEY <jon.turney at dronecode.org.uk>
> ---
> glx/glxscreens.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/glx/glxscreens.c b/glx/glxscreens.c
> index 386987e..037b037 100644
> --- a/glx/glxscreens.c
> +++ b/glx/glxscreens.c
> @@ -174,7 +174,7 @@ static char GLXServerExtensions[] =
>     "GLX_SGIS_multisample "
> #endif
>     "GLX_SGIX_fbconfig "
> -    "GLX_SGIX_pbuffer " "GLX_MESA_copy_sub_buffer " "GLX_INTEL_swap_event";
> +    "GLX_SGIX_pbuffer " "GLX_MESA_copy_sub_buffer ";
> 
> static Bool
> glxCloseScreen(ScreenPtr pScreen)
> -- 
> 1.7.9
> 
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
>